Skip to content

Test the npm and pnpm installations in one job per OS - #9277

Merged
cknitt merged 1 commit into
masterfrom
ci-merge-installation-tests
Nov 10, 2026
Merged

cknitt merged 1 commit into
masterfrom
ci-merge-installation-tests

Conversation

@cknitt

@cknitt cknitt commented Nov 9, 2026

Copy link
Copy Markdown
Member

Each run started 8 installation-test jobs: npm and pnpm on each of 4 OSes, about 20–60 s of work each. Two of them ran on macOS, where runners are the scarcest: today, with several PRs pushed at once, macOS jobs waited 4–10 minutes for a runner.

test-installation now installs with npm and then with pnpm, in separate temp directories, in one job per OS. The pnpm steps also run when an npm step fails, so a run still reports both package managers.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Kbf3gKHFTuMrZosy3Nb5Qc

Each run started eight short installation jobs, two of them on macOS,
whose runners are the scarcest; four jobs now test both package managers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kbf3gKHFTuMrZosy3Nb5Qc
Signed-off-by: Christoph Knittel <ck@cca.io>
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Changelog

No changelog entry.

Semantic Diff

1 commit · Full page

Test the npm and pnpm installations in one job per OS

d5689e4 · cknitt + Claude · Nov 09, 2026, 13:50 UTC

Each run started eight short installation jobs, two of them on macOS, whose runners are the scarcest; four jobs now test both package managers.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

✅ Compiler benchmarks

Allocated words

In total: 685,975,139 → 685,973,832 (±0.00%).

None of the 261 benchmarks changed by 0.1% or more.

Instructions

In total: 9,675,831,114 → 9,675,831,114 (±0.00%).

None of the 33 benchmarks changed by 0.1% or more.

Output size

In total: 28,859,904 → 28,859,904 (±0.00%).

None of the 13 benchmarks changed by 0.1% or more.

Pull request d5689e4 compared with base e941d27 in this run.

@cknitt cknitt added the changelog:skip No release notes needed label Nov 9, 2026
@pkg-pr-new

pkg-pr-new Bot commented Nov 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9277

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9277

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9277

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9277

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9277

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9277

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9277

commit: d5689e4

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

@cknitt

cknitt commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T19:55:16.012918Z d5689e4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: d5689e4fda

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cknitt
cknitt marked this pull request as ready for review November 9, 2026 20:06
@cknitt
cknitt requested a review from fhammerschmidt November 9, 2026 20:06
@cknitt
cknitt merged commit 53a934d into master Nov 10, 2026
33 of 36 checks passed
@cknitt
cknitt deleted the ci-merge-installation-tests branch November 10, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip No release notes needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants